
Design comparison
SolutionDesign
Community feedback
- P@SaiDineshKopparthiPosted 4 months ago
1. Semantic HTML
- Try to use semantic HTML for better accessibility and structure. Since there is only one main section, wrap it in a
<main>
tag to define the primary content clearly. - Improve the
alt
attribute for theimg
tag. This text is crucial for accessibility tools and should provide meaningful descriptions of the images.
2. Font Application
- The font is not being applied as intended. I suggest reviewing the
@font-face
declaration and ensuring the path to the font file is correct.
3. Font Size Units
- Consider using
rem
units instead ofpx
for font sizes.rem
units allow for better scalability and responsiveness, especially for users who modify their browser's default font size.
4. Color Management
- Use CSS variables for defining colors instead of hardcoding them. CSS variables make it easier to maintain and update the color scheme across the project, improving flexibility and consistency.
1 - Try to use semantic HTML for better accessibility and structure. Since there is only one main section, wrap it in a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord