Skip to content
Submitted about 2 years ago

Resposive 3-column preview card using CSS custom properties

Kelly CHI•210
@KellyCHI22
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hey there, thanks for reviewing my code. This is my #6 challenge! I used CSS custom variables in this project, which is indeed very practical and makes the code drier and more readable. Feel free to give me any feedbacks!

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @Hsin-tingCHI, some suggestions to improve you code:

    • To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
      <body>
      <main>
        <article>
          <article class="sedan-card"></article>
          <article class="sedan-card"></article>
          <article class="luxury-card"></article>
        </article>
      </main>
    </body>

    The Main Element identifies the main content of the document.

    While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.

    Lastly, each card will be wrapped in their own Article Element because they too, are complete, or self-contained, section of content that is, in principle, independently reusable.

    More info:

    https://web.dev/learn/html/headings-and-sections/

    • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

    • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

    Happy Coding! 👻🎃

    Marked as helpful
    0
    Kelly CHI•210
    @KellyCHI22Posted about 2 years ago

    Hello @vcarames! Thank you so much for your suggestions! 🥰 I've updated the markup accordingly. 👍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord