Design comparison
SolutionDesign
Community feedback
- @visualdennissPosted over 1 year ago
Hey there,
Good job completing the challenge successfully! I'd have a suggestion regarding best practice:
- Try to avoid giving fixed height or max-heights for elements/containers that contain text elements. It will cause accessibility issue, when user changes their default font-size, text will overflow and break the layout, instead use paddings inside the container if necessary. It is better to use min-height etc. but never a fixed height.
Instead you can add some more padding if you want to match the height to the design etc.
Hope you find this feedback helpful!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord