Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsiveness using flexbox

Jumagobe 1,050

@Jumanjigobez

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Difficulty only on responsiveness and also the padding of the qr image but now am good and understood the use of flex-box. I am a beginner and at-least give me some feedback I will appreciate.This is my first trial.

Thank you frontendmentor.io

Community feedback

Radek 490

@Radexman

Posted

Hi there! I looked through your code and if you don’t mind I will provide some feedback :).

So first of all it is good to separate our styles and html, for small projects it is acceptable to write our css inside html but we usually write it in a separate file and then connect it via link tak inside the head element.

It appears that you don’t use <h1> element which is necessary to include even in small projects, we want to use heading hierarchy which starts with<h1> and moves to <h6>, it improves readability of our code and helps screen readers to understand content of our page better. Here is some good resource on that:

https://www.contentkingapp.com/academy/headings/

Hope it was helpful for you at least a little bit ;)

Good luck on next projects and happy coding!

Marked as helpful

1

Jumagobe 1,050

@Jumanjigobez

Posted

@Radexman Thanks man I appreciate your feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord