Responsive-interacting-rating-component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @liniii31, Congratulations on completing this challenge!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.You made your html structure entirely with div blocks but these div doesn't any semantic meaning, for this reason is better you use a better html markup improving your code, for example for the card you use <main> instead of the <div>.

  2.Replace the <div> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

  3.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Shalini Anand•180

  @liniii31Posted about 2 years ago

  @correlucas Thank you so much.

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @liniii31,

  Congrats on completing the challenge

  I would suggest just disabling the button until a rating is selected this can be done by adding the disabled attribute on the button and removing it when the rating is clicked currently when you click without selecting a rating it's gives you undefined.

  Hope this is helpful.

  Marked as helpful

  1

  ---

  

  Shalini Anand•180

  @liniii31Posted about 2 years ago

  @hyrongennike Thank you.i have done the changes.

  0