Responsive-fylo-data-storage-component-made-with-CSS-Grid-system

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these steps:

  ✅ it is better to use a single style of access to elements (classes, or idi)

  let input = document.querySelector ('input')
  let volume = document.getElementById ('volume')
  

  ✅ It is better to delete comments from the repository

  // progress.style.left = (input.value / 1.1) + '%'
  

  ✅ Try to avoid oninput, it is better to use addEventListener instead.

  ✅ For security reasons, it is better to install textContent instead of innerHTML

  I hope my feedback will be helpful. You can mark it as useful if so 👍

  Good luck and fun coding 🤝⌨️

  1

  ---

  

  Amine•90

  @UsernameUTFPosted over 2 years ago

  @isprutfromua ok Thanks bro

  0

  

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  @UsernameUTF I'm glad that my comment was helpful to you.

  Contact me if you have any questions

  Cheers

  0

  

  Amine•90

  @UsernameUTFPosted over 2 years ago

  @isprutfromua thanks ok

  0