Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive-Flex-Qr-card-design

creatored 50

@creatored

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

The fact that i'm seeing a lot of improvement in my code

What challenges did you encounter, and how did you overcome them?

Had a problem with centering the qr box but then i tried using flex and it worked perfectly

What specific areas of your project would you like help with?

Maybe the Typography

Community feedback

P

@tdimnet

Posted

Hi creatored,

Nice project so far! It looks nice both on mobile and desktop devices.

I think the line below be a h1 tag instead of a span:

<span>Improve your front-end skills by building projects</span>

You could add a better descriptive description for the alt tag. Don't forget it used for screen readers.

Why did you create a JavaScript file? You don't seem to use it.

You did a good job for your first project :).

1

creatored 50

@creatored

Posted

@tdimnet Thanks for pointing out the use of span element and alt tag! I forgot to remove the Javascript file before submitting it. Thanks for the feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord