Design comparison
Solution retrospective
An another try on deploying a proper responsive web design by me. Feedbacks are highly appreciated🥰😊.
Community feedback
- @AydanKaraPosted over 1 year ago
Congratulations SHASHIDHAR. I would like to suggest some feedbacks to make your project look better. If you set at @media (max-width: 950px) width: 90% and margin: auto from class="part-container", this will center the container exactly. Also, the height would be better if it were 100%, so as not to overlap the container with the attribution class below.
Another thing that will be useful for you is to set part 1, 2 and 3 flex-basis: 100% in @media (max-width: 950px). So the boxes will correctly take the padding: 50px 20px 40px 50px that you set on the parts class.
You can also change some html tags to Improve Accessibility: You can change the <div> tag with class="part-container" to a <main> tag and a <div> of class="attribution" on the <footer> tag.
I hope you find these improvements useful. I wish you a pleasant day.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord