Responsive workit landing page with Grid and Flex

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 1 year ago

  Hi Mika

  • <img src="img/logo-light.svg" alt="Workit Logo"> , the logo will usually be in a link as that will be a link to the homepage.
  • the apply for access button in this case should as well be a link to another section or page, a button is used for cases like opening a menu or submitting a form. Find out more on the difference use cases of buttons and anchor elements.
  • decorative images (the patterns) should have an empty alt value, the phone image does not appear to be decorative in my opinion - it should be the one with an alt value with a message.

  Marked as helpful

  1

  ---

  

  Mika•230

  @mikatechsPosted about 1 year ago

  @ChamuMutezva, Thanks a lot for the tip. Appreciate it.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted about 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ANCHOR ELEMENT 🔴:

  • Those social image you have used on footer needs to be an actual link for proper navigation.

  ---

  • They are not for decoration, So we need to wrap each of the images using <a> element with aria-label attribute which is way more important for social links in an <a> tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.

  ---

  • When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an aria-label attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.

  ---

  • By providing this additional information, you can help users with visual impairments to better understand the purpose and value of social links, and encourage them to engage with your content. This can ultimately improve the user experience on your website, and make it more accessible and inclusive for all users.

  ---

  • Example:

  <a href="#" aria-label="Facebook profile of Workit">
      <img src="img/icon-facebook.svg" alt="" class="footer__logos-fb">
  </a>
  

  ---

  • If you have any questions or need further clarification, you can always check out my submission for another newbie challenge where i used this method and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Mika•230

  @mikatechsPosted about 1 year ago

  @0xAbdulKhalid, appreciate your feedback. Thank you for the tips.

  0