Responsive with scss and flexbox

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  well I think it is good, but since your using scss, you could make use of BEM selectors, where you use &__, for the scss selectors so that it will be pretty to see and more compact^

  1

  ---

  

  Tim Leonard•40

  @iamtimleonardPosted over 3 years ago

  @pikamart thanks. I hadn’t heard of BEM so I’m glad to know about it now!

  0

  

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  @iamtimleonard you're welcome, just ask here if you need more clarifications^

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, Tim Leonard! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Well done on this one! 👍 Your solution looks great and responds well! 🙌 I like the animation on the mobile menu! 👏

  Like pikamart mentioned, looking into using BEM for your class names would be a good idea. It works very nicely with Sass's nesting feature! 🙂

  Oh, and one super tiny suggestion I have is to add cursor: pointer to the menu button.

  Keep coding (and happy coding, too)! 😁

  0