Responsive with Flexbox, CSS Grid and Pure Javascript

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  Hi João, first off, great job completing this, even though there were many difficulties along the way.I'm happy to hear you got the feeling of satisfaction after completing this (which is always a great feeling!), and hopefully later you can come back and make some fixes to make it even better! 🙂

  You do have a number of issues in your report; to fix the main landmark issue, simply add a main tag under your body tag. For the ones about "links must have discernible text", this is because you are using a tags for the "settings" icon in the card. I would use a button instead because this is not a link, as in, links are for navigating to another page. Another issue has to do with button not needing href, which should only be for links, so you just need to remove the href and that should be OK. Anyway, do look through those issues, and hope you can get them sorted!

  Also, I see that you are using an XMLHttpRequest to fetch data; I think you can try simply using fetch(), which is what I used when I first did this challenge. I'm now using a different method where I have some helper objects in another file, and I just imported them into my main JS file. Anyway, here's my solution that you can check out and see whether that gives you some ideas: https://www.frontendmentor.io/solutions/responsive-dashboard-using-scss-and-vanilla-javascipt-with-json--HVkNhdtJT

  Hope this helps, and great job in completing this challenge!

  Marked as helpful

  0