Responsive with Flexbox, CSS Grid and Pure Javascript
Design comparison
Solution retrospective
Well, I had to test a lot to get to the end of this project, console.log() behind console.log(), I read article after article to do some things I didn't know so I could learn a lot, probably when I come back to it in the future I want to change some things but for now I'm very satisfied
Community feedback
- @elaineleungPosted about 2 years ago
Hi João, first off, great job completing this, even though there were many difficulties along the way.I'm happy to hear you got the feeling of satisfaction after completing this (which is always a great feeling!), and hopefully later you can come back and make some fixes to make it even better! 🙂
You do have a number of issues in your report; to fix the
main
landmark issue, simply add amain
tag under yourbody
tag. For the ones about "links must have discernible text", this is because you are usinga
tags for the "settings" icon in the card. I would use a button instead because this is not a link, as in, links are for navigating to another page. Another issue has to do withbutton
not needinghref
, which should only be for links, so you just need to remove thehref
and that should be OK. Anyway, do look through those issues, and hope you can get them sorted!Also, I see that you are using an
XMLHttpRequest
to fetch data; I think you can try simply usingfetch()
, which is what I used when I first did this challenge. I'm now using a different method where I have some helper objects in another file, and I just imported them into my main JS file. Anyway, here's my solution that you can check out and see whether that gives you some ideas: https://www.frontendmentor.io/solutions/responsive-dashboard-using-scss-and-vanilla-javascipt-with-json--HVkNhdtJTHope this helps, and great job in completing this challenge!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord