responsive with flex and bem methodology

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Mateo Sarubbi,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • About <h1>it is recommended not to have more than one h1 on the page. Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. Then swap those <h1> by <h2>.
  • What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
  • In this challenge, the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images.
  • Don't capitalize in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalized text as they will often read them letter by letter thinking they are acronyms.

  Hopefully this feedback helps.

  Marked as helpful

  1
• 

  David•8,000

  @DavidMorgadePosted over 2 years ago

  Hello Mateo, congrats completing the solution of this challenge!

  As first, I would try to center all the 3 columns on the middle of the screen, you can get this by using flex-box on the body and adding a min-height: 100vh (so the body takes the whole screen and then with flex you can center everything), if you want to try it, add this to your body:

  body {
    background-color: hsl(0, 0%, 95%);
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  With this it will get completely centered by flex!

  It would also be nice if you add some :hover in your buttons, for example you can swap the color of the buttons with the background-color and vicerversa, also adding a transition to that can be a quite cool effect, you can add this for example to your code:

  .btn {
     transition: all 0.5s ease;
  }
  .btn:hover {
       background-color: /* here use the previous color */
      color: /* here use the previous background color */
  }
  

  Hope my feedback helps you in future projects, good job!

  Marked as helpful

  1