Responsive website using Sass flex and grid mobile first

Community feedback

• 

  hardy•3,660

  @hardy333Posted about 3 years ago

  Hey, website looks super clean and nice. You even added purple borders on Patrick's and Daniel's profile images, the fact that you don't miss that detail is quite impressive -- GOOD JOB.

  In terms of your code I have few suggesstions:

  • In html everything looks good, only thing you can maybe think of changing is to use dame className ".card" on card elements instead of .card1, card2 and so on , taht way your .card has all the same styles and then you modify them with your .light, .dark classes.
  • in scss, dont nest selectors in body, that is just useless and adds additional nested parent which is not that good, in general in scss too much nesting is not very good.

  Marked as helpful

  4