Responsive website using HTML and CSS. A nice perfume-card.

Community feedback

• 

  P

  Steven Stroud•11,890

  @StroudyPosted 2 months ago

  Hey great job getting it so close to the original, some things I noticed,

  • Displays images with incorrect aspect ratio, Image display dimensions should match the natural aspect ratio, Check out this CSS aspect-ratio Property from w3school,
  • Missing a <meta> description tag for SEO purposes,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • You should avoid using ID selectors # and use class="" Instead because #ID is usually used for JavaScript or other reasons not styling.
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Line height is usually unitless instead of line-height: 150%; should use line-height: 1.5; this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately.

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  1

  ---

  

  AliRM27•40

  @AliRM27Posted 2 months ago

  Thank you very much for your helpful tips!@Stroudy

  1