Responsive Website using CSS Grid

Community feedback

• 

  P

  thibault.deverge•290

  @thibault-devergePosted about 2 months ago

  Hi, overall your solutions are great! I do see a few areas for improvement:

  Try to use CSS properties instead of <br> tags, as the spacing is purely decorative (refer to the separation of concerns principle). Use more semantic elements instead of simple <div> tags (e.g., <section>, <main>, etc.). For instance, using a <main> tag would be better than a simple <div> in this case. Your solutions are slightly narrower than the original. You can see this in details like the text alignment, which is off. Additionally, the padding and spacing aren't quite the same overall. Figma is usually free for this project, so if you can learn to use it (spoiler: it's not too hard), it will greatly enhance your ability to translate design into code. This also applies to your box-shadow, which is a bit harsher compared to the original design.

  This might seem like a lot, but these are small details. Overall, your work is really good. Well done, and good luck with your next project! :)

  Marked as helpful

  0
• 

  Franck kapuya•40

  @choupolePosted about 2 months ago

  it's good

  0