Responsive website navbar with JS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Jfpccaballero , great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add header tag and wrap the navbar for improve the Accessibility
  • use main tag for wrap the ontent of page
  • add footer tag and wrap the footer for improve the Accessibility
  • use ul for the text of navbar istead a div
  • using <hr> for the line of mobile menu is not the best way because this tag have a semantic meaning... in this case use border property because this line is decorative
  • add descriptive text in the alt attribute of the images
  • add transition to the button

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0