Design comparison
Community feedback
- @groverrichardsonPosted over 2 years ago
Hey! Great attempt. However, visually some things seem a little off. The font-family is not correct and the main text is too large. Be sure to adhere to the font-sizes provided. It looks like maybe the full snippet from Google Fonts wasn’t pasted in your head.
Also, for images, be sure to include alt text. It’s a necessity for accessibility.
I also noticed that your file doesn’t have an JavaScript and all styling was done inline via Tailwind. I would recommend separating the html file out into separate styling and JavaScript files. That way it’s easier to read in the future.
But I didn’t see any javascript in the project at all. So the app doesn’t work and is currently static. I would double back to this and make sure you’re calling the API provided and updating the text from the response.
Marked as helpful0 - @chirag631Posted over 2 years ago
First of all thanks for seen my work, I'll work on this points.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord