Qr code component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @lumon2004, some suggestions to improve you code:

  • It is best practice to have separate files for you HTML and CSS code. It helps keep things organized and make it easier to maintain.

  • The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • Do not use VH/VW for your values. It cause your component to shrink/grow indefinitely.

  Happy Coding! 👻🎃

  0

  ---

  

  Luca•90

  @lumon2004Posted about 2 years ago

  Hi @vcarames, I already know that it's good use to separate HTML and CSS code in different files, but I'm doing everything in one file just for these challenges just to have a more comfortable publishing process. And regarding to the vh/vw, usually I use the percentage as unit of measure but I'm experimenting those units trying to reach a more comfortable and smarter level of responsivity of a webpage.

  0