Skip to content
Submitted over 4 years ago

Responsive webpage using HTML & SCSS (with flexbox)

Natalie Clamp•230
@NatClamp
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Is my SCSS efficient? How browser-compatible is my code? How could my HTML be more semantic - have I used the HTML5 tags correctly?

Community feedback

  • Edgar Burtnieks•465
    @edburtnieks-privatePosted over 4 years ago

    Hey Natalie :)

    Your styling with SCSS in general looks great. There are some inconsistencies with variable names. Neutral colors are PascalCase whereas rest are camelCase. Also, it's not necessary to put tag selector in front of class selector for sections.

    As for semantic tags and accessibility. Only thing I noticed are alt attributes for icons. You should have some meaningful text that describe the icon itself. Or if you want to leave as purely decorative and not for screen readers, you could leave alt attribute empty.

    Otherwise everything looks good. Nice work :)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord