Submitted over 1 year ago
responsive web design by viewport, using some of the CSS properties.
@Kumara002
Design comparison
SolutionDesign
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello Nanba 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution consists incorrect usage of
<h4>
so it can cause severe accessibility errors due to incorrect usage of level-four headings<h4>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- In this solution there's a
<h4>
element which is this<h4>Improve your...</h4>
, you can preferably use<h1>
instead of<h4>
. Remember<h1>
provides an important navigation point for users of assistive technologies so we want to use it wisely
- So we want to add a level-one heading to improve accessibility
- Example:
<h1>Improve your front-end skills by building projects</h1>
- If you have any questions or need further clarification, and feel free to reach out to me.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @istealersn-devPosted over 1 year ago
Great efforts, Congratulations!!
In order to center your card, you can use the following within the body tag, this will center it for both x and y axis
body { display: grid; place-items: center; }
Also for HTML structure, you should make use of
<main>
tag to define the content body and use<h1>
as each page must contain at least 1 top heading as per web standards; it helps boost SEOHope this is helpful!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord