Responsive web component built using HTML, CSS, CSS flexbox, e.t.c.

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Usuanlele , Congratulations on completing this challenge!

  I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code.I saw that you’ve used id to give the styling for your component, its not a good idea because id its a too much specific selector used for forms and Javascript code. Instead, use class for styling and let the id for much specific stuff.

  It is not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Usuanlele Osahon•135

  @horsirhonPosted about 2 years ago

  @correlucas Thanks for the tips , I really appreciate someone with experience looking through my code and commenting to help me improve

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Usuanlele, congratulations on completing the challenge, great job! 😁

  Some little tips:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  1

  ---

  

  Usuanlele Osahon•135

  @horsirhonPosted about 2 years ago

  @denielden Thanks for the tips, I'll make these changes soon.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @horsirhon You are welcome and keep it up 😁

  0