Responsive web app using css grid and flex box

Community feedback

• 

  Darren Bawag•115

  @darrenbawagPosted over 3 years ago

  Tested the site. Nicely done. You nailed the styling :) good naming convention for classes/ids 🔥🔥

  Just don't forget the report for Accessibility issues and HTML issues.

  • provide alt tag for images <img class="arrow__icon" src="images/icon-arrow-down.svg" alt="arrow down" /> for screenreaders/accessability reason
  • I suggest to remove all # to all links with href and have it urls just like this

  <a href="https://facebook.com/"><i class="fa fa-facebook-square"></i></a>
  <a href="https://www.instagram.com/"><i class="fa fa-instagram"></i></a>
  <a href="https://twitter.com/"><i class="fa fa-twitter"></i></a>
  <a href="https://www.pinterest.com/"><i class="fa fa-pinterest"></i></a>
  

  That's it. Happy Coding! 😊

  Marked as helpful

  0

  ---

  

  satish-maurya•20

  @satish-Maurya-4Posted over 3 years ago

  @darrenbawag thanks a lot darren for the feedback.

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  I checked it on mobile and it is looking good. But I cannot view your code in the github repository for some reason

  0

  ---

  

  Darren Bawag•115

  @darrenbawagPosted over 3 years ago

  @ChamuMutezva it's in another branch 'master'

  0