Submitted over 3 years ago
Responsive web app using css grid and flex box
@satish-Maurya-4
Design comparison
SolutionDesign
Solution retrospective
I have written more code for service section, can same action could be done with less code.
This is my very first project on this amazing platform.
Community feedback
- @darrenbawagPosted over 3 years ago
Tested the site. Nicely done. You nailed the styling :) good naming convention for classes/ids 🔥🔥
Just don't forget the report for Accessibility issues and HTML issues.
- provide
alt
tag for images<img class="arrow__icon" src="images/icon-arrow-down.svg" alt="arrow down" />
for screenreaders/accessability reason - I suggest to remove all
#
to all links withhref
and have it urls just like this
<a href="https://facebook.com/"><i class="fa fa-facebook-square"></i></a> <a href="https://www.instagram.com/"><i class="fa fa-instagram"></i></a> <a href="https://twitter.com/"><i class="fa fa-twitter"></i></a> <a href="https://www.pinterest.com/"><i class="fa fa-pinterest"></i></a>
That's it. Happy Coding! 😊
Marked as helpful0@satish-Maurya-4Posted over 3 years ago@darrenbawag thanks a lot darren for the feedback.
0 - provide
- @ChamuMutezvaPosted over 3 years ago
I checked it on mobile and it is looking good. But I cannot view your code in the github repository for some reason
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord