Submitted over 1 year ago

Responsive web app made with JS and CSS

Amy Spencer•300

@amyspencerproject

Preview site View code

This is a solution for...GitHub user search app

HTML
CSS
JS
API

2junior

Design comparison

SolutionDesign

Solution retrospective

For this challenge I applied the preferred user theme by setting a 'data-theme' attribute on the root element (instead of applying a theme to each individual element). I attempted to use radial buttons to switch the user theme but I might come back and refactor parts of this. Feels like I might have made it too complicated.

I enjoyed this challenge a lot but wanted so badly to build it with React 😉

Let me know what you think!

Community feedback

Arne•1,110
@DudeldupsPosted over 1 year ago
Hello 👋🏻

There seems to be an issue in your JS:

Your getUser function doesn't work, you are using a variable inside the function before initialization.

Also both the classname and id for your form element are a bit misleading, I think mentioning the word "form" in any way would be more suitable. search-submit sounds more like the submit button 🙂
Marked as helpful
1
Amy Spencer•300
@amyspencerprojectPosted over 1 year ago
@Dudeldups Thank you for telling me!
0
Amy Spencer•300
@amyspencerprojectPosted over 1 year ago
@Dudeldups

It should work now! I looked your git username up and the function ran successfully. I had called the variable "handle" in the getUser function before declaring it. Your account profile was an edge case I didn't account for last night since you don't have designated user name listed on your account.

Thank you so much for reviewing my code and catching this error!
0
Arne•1,110
@DudeldupsPosted over 1 year ago
@amyspencerproject I'm glad it helped 👍🏼
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord