Design comparison
Community feedback
- @C3SC0-V4113Posted 7 months ago
Hi! Love the animations and life you give to your solutions! However i find a flaw and its the search is not working properly, you have and autocomplete text input but even if you select an option doesnt work properly. i was seeing this text input changed the url when submited (also returned the theme to light mode), i try to test if the search of the country was based by url parameters, but launched a router error, if you are using react router dom you can add custom error screens so the flow of the page is nos disrupted, remember that you have to do some configurations depending of you deploy service
Also there are some design preferences a would like to say The detail page doesnt look equilibrated, and seems heavier in the left side of the screen Also you didnt use any of the icons the original design has
Marked as helpful0@LocoyoccimPosted 7 months agoHello, thank you for your feedback. I have revisited the solution and found the errors you mentioned. I will now begin exploring options to optimize it and upload it back to production! My main focus initially will be to resolve the issue with URLs when reloading the page while being outside the main page.
"By the way, I'm from Mexico and I also speak Spanish."
@C3SC0-V4113
1@C3SC0-V4113Posted 7 months ago@Locoyoccim espero que puedas solucionar los errores, si usas React Router Dom puedes usar los enrutadores de errores, tambien ten en cuenta que dependiendo del servicio, esos errores de recarga tienen distintas soluciones, busca como solucionar ese error en Netlify, en vercel que es donde yo subo los mios es solo de agregar un documento de configuración de dos lineas y se soluciona. Tambien hablo español, soy salvadoreño :) Conectemos por LinkedIn si deseas
Marked as helpful0@LocoyoccimPosted 7 months agoClaro que si, enseguida se busco por ese medio! Gracias por el feedback! @C3SC0-V4113
1 - @LocoyoccimPosted 7 months ago
"I have fixed some bugs and also corrected the dimensions of the cards."
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord