Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Your session has expired please log in again.
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Vehicle Cards

@Bazza-08

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@Mitko90

Posted

Hi, nice solution.

It looks great.

Maybe you can check some suggestions I have for you:

  • You used three times the <h1> heading. This heading should only be used once. Maybe change it to <h2> as it can be reused. Of course every page should have an h1 heading so I suggest adding a visually-hidden one to the page, so it doesn't generate an accessibility report.
  • Your buttons should direct the user to a different part or page of the site. So maybe switch the <button> with the <a> tag.
  • You generated a report All page content should be contained by landmarks . To fix it simply replace your <div class="container"> with <main class="container">.

I had similar mistakes when I did this challenge so I redid it with the changes. You can, if you want, check both of my submissions here and here.

Above all the solution you submitted looks great.

Happy coding.

Marked as helpful

1

@Bazza-08

Posted

@Mitko90 Thank-you! Appreciate the feedback!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord