Design comparison
Community feedback
- @gregoriofrancisco99Posted almost 2 years ago
Hey, pal! Your solution looks stunning, congratulations 🎉. Although there's a little space for improvement.
Saw that you set
html, body{height: 100%;}
. Well, this is not really wrong, but also this is not something we do often. And because of this, on mobile devices, it's impossible to see your solution completely. But you can solve it applying the following settings to your stylesheet:html, { height: auto; /* Or just remove it 😅*/ } body { height: 100vh; }
Noticed that you have two
height
properties conflicting in you main tag style. Resolving that should make your .css happy 😊. And if you already have a main tag encapsulating everything, I would advice you to remove thediv class="container"
.Well those are my suggestions.
And remember... Keep coding 💻
Marked as helpful1@jelsonmitaPosted almost 2 years ago@gregoriofrancisco99 Thanks a lot bro, I'll make a point of correcting it right away.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord