Design comparison
SolutionDesign
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @FernandoChurros 👋, good job completing this challenge! 🎉
I have some suggestions you might consider to improve your code:
- You have a typo in your CSS variables, update
-font-family
to--font-family
.
- Instead of using pixels in font size (
font-size: 15px;
in the body), use relative units of measure likerem
orem
. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
- To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.
Above all, the project is done well👏. I hope those tips will help you! 👍
Good job, and happy coding! 😁
2 - You have a typo in your CSS variables, update
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord