Responsive Using FlexBox.

Community feedback

• 

  vladjsp•40

  @vladjspPosted over 1 year ago

  Hi. I like your solution. It is much better than mine but here's what i see for improvement (keep in mind I'm an intern/junior level). In the js file, you can replace this block of code: dayD.innerText = '--'; monthD.innerText = '--'; yearD.innerText = '--'; by creating a function (resetResult()) for example and replace all 7 of these blocks. It will be more readable and correct due to SOLID principles. The same you can do with class adding and removing. You just can create function that take parameter and replace all boilerplate code (more than 15 replacement).

  CSS. Input fields bounce when an error message appears. You can add 'position: relative' to your 'date-input' class and 'position: absolute; top:85px' to id 'invalid-date'.

  Marked as helpful

  0