Design comparison
Solution retrospective
Im proud of the fact I made it responsive, but next time I would like to learn what are the industry standard breakpoints. Also if it was better to use flexbox or css grid. Im not sure when you should use either one
What challenges did you encounter, and how did you overcome them?It was a challenge to get the breakpoints to seemlessly transition. Also it was hard to get my title of the page to line up with 2 lines of equal length, im not sure i did it right because it looks stretched in some cases. But i did research and tried my hardest.
What specific areas of your project would you like help with?Trying to get my title lines to be the same length without stretching so much?
Community feedback
- @luisgustavogorniakPosted 3 months ago
Nicely done! Looks really close to the design! I can see you put a lot of effort in it!
To answer your first question,
flexbox
andgrid
are CSS rules that basically do the same thing, but the best practices are to use grid when its for building a complex layout and flexbox is just for align elements.If you're interested in build a table-like layout,
grid
is a go, but if you're trying to align elements inside the cells of the grid created table,flexbox
is the best choice.About the responsiveness of the page:
- I see you worried about the UX by adding a lot of media queries for differents viewports of differents type of devices. In this kind of job its better that you keep it simple, a single media query call just for when the viewport is for a mobile device is enough.
- That said, my advice is to adhere to the concept of mobile first. Today is importanter that you first build your code to work on mobile devices first, and then you add the media query for its no longer a screen of a mobile device, like:
@media screen and (min-width: 784px)
.
You'll see that its much less work and your code will look cleaner.
Lastly, about your titles, they look streched because they're using the same
h1
element, and its parent element is setted to have a static width. Try removing the width rule and separating the titles withh1
tag for each, and change the parentdiv
rules forflexbox
andtext-align
, like this:.bigText { display: flex; flex-direction: column; text-align: center; }
I hope my review is helpful, my friend! Have a good one and keep coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord