Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

responsive using css media query , sass variable, rem, em

P
yoyov51234 240

@yoyov51234

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

  1. Learned media query.
  2. Thinks about the responsive design

What challenges did you encounter, and how did you overcome them?

  1. The flex box were not equal in width even though I set flex:1 for each flex item. I gave each flex item 50% so that they are equal in width in the end.

What specific areas of your project would you like help with?

There are only 2 designs , how do we know the margin within other designs? how to shirk corresponsive without every media query?

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.
  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.
  • Example:
<picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
</picture>
  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.
  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

1

P
yoyov51234 240

@yoyov51234

Posted

@0xabdulkhalid Hi Abdul, Thanks you very much for the sharing, that's a brilliant way of dealing the different sources!

I will update my solution with your suggestion, thank you very much! Side note: English is not my mother tongue, and I learned from the way you express things too, followed you just now, will keep learning from you. Thanks.

0

@0xabdulkhaliq

Posted

You're welcome @yoyov51234 !

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord