Design comparison
SolutionDesign
Community feedback
- @AbimzzPosted 3 months ago
First and foremost, I want to commend you on the great job you've done with the site! it’s clear that you’ve put a lot of effort into this project.
I did notice a few areas that could benefit from some adjustments:
-
Border Radius on Images
- The
border-radius
property is currently applied to all four corners of the images. It would be more visually appealing to apply it to only two sides, which can create a more refined look.
- The
-
Card Body Height
- The height of the
.card-body
should be adjusted to match the height of the image. This will create a more cohesive appearance and ensure that the layout is balanced.
- The height of the
-
Image Alt Text
- The
alt
attribute in the<img>
tag is essential for accessibility. It should be used to describe the image in case there is an error in loading it. This not only improves accessibility for users with screen readers but also enhances the overall user experience.
- The
-
Breakpoint Adjustments
- The breakpoint for the site needs to be reconsidered, especially regarding the effects of both paddings and margins. Ensuring that these elements are accounted for will help create a more responsive design.
-
Mobile View Spacing
- There seems to be a lack of space between the card and the body in the mobile view. Adding some margin or padding will improve the layout and make it more visually appealing on smaller screens.
-
Cart Icon Color
- The cart icon currently has a
color: black;
style applied. Changing this tocolor: white;
would enhance visibility and align better with the overall design aesthetic.
- The cart icon currently has a
Overall, your work is commendable, and with a few adjustments, it can be even better. I appreciate the effort you've put into this project, and I look forward to seeing how you implement these changes. Keep up the great work!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord