Responsive using CSS Grid and Flexbox - Mobile First

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Desktop layout looks great, it is responsive as well and the mobile state looks great.

  Some suggestions would be:

  • Wrap the .attribution inside a footer so that it is inside a landmark element.
  • On the .card using margin to place the content center is not consistent enough. I always recommend using these props:

  align-items: center;
  display: flex;
  flex-direction: column;
  justify-content: center;
  min-height: 100vh;
  

  To the parent container of the element to center it properly, it could be set to the body tag , though you would need to adjust the margin on the .attribution.

  • Your .stat_data could have used ul since those are "list" of information about the company website.
  • Also, inside in those list information, those text should not be using a heading tag because they don't really give content on what the section would contain right, so better using p tag on them.

  Aside from those, great job again on this one.

  Marked as helpful

  0

  ---

  

  Pablo Clemente•60

  @PabloMClementePPosted about 3 years ago

  Thanks a lot @pikamart, your feedback is very helpful

  1