Design comparison
Solution retrospective
Everything seems to be working, but if you find an issue or have a suggestion on how to improve my code, or just want to ask me a question, I will be happy to hear from you!
Community feedback
- @aUnicornDevPosted over 3 years ago
Great work man. ✌✌✌
This is by far the best solution for this particular challenge that I've seen.
Just a minor issue is that when changing the tip, the counter starts from undefined to and reaches upto the final calculated value. It's barely visible because of the speed of the counter but i thought I should mention it.
Few improvements apart from this challenge would be to have a default tip and an active state for the bill input field after website load.
0@olgak169Posted over 3 years ago@aUnicornDev Hi! Thanks for your feedback! That brief undefined flash bothered me too)) I just couldn't find what is causing it since it doesn't show up for every input. I'll just have to make some adjustments to the output values, I guess. I thought about setting a default tip, but design looks like it doesn't have one, so I skipped that. Thanks again for your suggestions, always good to hear what people think!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord