responsive tip calculator, html, scss, and vanilla javascript

Community feedback

• 

  Paola•320

  @paolas771Posted over 2 years ago

  Hi you do a great job! Another way you can have a smooth effect is by having an event listener on the number of people input so when user enters a number it automatically updates. Here is my solution if you want to see what I mean https://www.frontendmentor.io/challenges/tip-calculator-app-ugJNGbJUX/hub/tip-calculator-app-with-javascript-G00OTLZW4

  0
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey sophiakoulen, good job completing this challenge. Keep up the good work

  Your solution looks good however I think the card needs some margin from the top. You can achieve this using margin-top

  In terms of your validation errors

  • Element field not allowed as child of element div in this context.

  • The type attribute is unnecessary for JavaScript resources

  In terms of your accessibility issues

  • form elements must have labels, you can achieve this using the label attribute in the input tag

  • wrap all your content between <main> tags to get rid of all accessibility issues

  I hope this helps

  Cheers Happy coding 👍

  0
• 

  Oussama Zouaine•250

  @OussamaZouainePosted over 2 years ago

  Great job @sophiakoulen.

  0