Tip Calculator using Sass and Vanilla JavaScript (Updates Realtime)

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Greetings Lance

  • id's must be unique, you cannot use an id more than once. A class is suitable for re-usability.
  • as for headings, an h1 element is supposed to be the first heading element on your site. Using only one h1 element is considered best practise. Headings should ascend in order where an h2 should follow an h1 (h1, h2 ,h3 etc).
  • the button should have a type, in this case i think reset will do.
  • change the div with a class of main into an html5 main element - that will also help to clear one of the errors mentioned in the report
  • form input elements are required to have labels for accessibility reasons

  Good lucky

  Marked as helpful

  1

  ---

  

  Lance Martija•185

  @lancemartijaPosted over 3 years ago

  @ChamuMutezva Thank you for your insights! I'll make sure to keep these things in mind once I start my next project.

  0
• 

  YksRocks•100

  @YksRocksPosted over 3 years ago

  This is awesome!

  Great job. Though I have to point out something not that it is very bad but when I want to type number of persons I have to scroll the page this is a very small thing but it will make it easier to use. I know you can easily fix this. Anyhow, well done.

  0

  ---

  

  Lance Martija•185

  @lancemartijaPosted over 3 years ago

  @YksRocks Oh, yeah. It tends to happen when you type on the input forms. It's not really a bug... or maybe it is? I'm not sure. Well, even on most websites with forms that support mobile view, it scrolls back to the input form when it's on focus. Anyway, I'll try to find a fix for that if it really is a bug. I'll make a quick adjustment as soon as I can. Thanks for the heads up!

  0