Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive tip calculator app using HTML5, CSS3, and JavaScript

TMJβ€’ 120

@TMJSMC53

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback is welcomed πŸ™‚

Community feedback

T
Graceβ€’ 29,310

@grace-snow

Posted

It's really important to use buttons for actions and anchor tags for links.

Also, the most important information on the page has been hidden from search engines and screenreaders. Is this product called "logo"?

Your other obvious report errors can be fixed by amending the ID/for attributes

Marked as helpful

0
Anosha Ahmedβ€’ 9,300

@anoshaahmed

Posted

To get rid of the accessibility/HTML issues shown in your Report:

  • wrap everything in your body in <main> ... OR use semantic tags ... OR give role="" to the direct children of your <body> ... Click here to read more
  • have at least one <h1> in your code
  • <section> and <article> usually need a heading; so if you don't need a heading in it, use some other element such as <div>

Great job! :)

Marked as helpful

0

T
Graceβ€’ 29,310

@grace-snow

Posted

@anoshaahmed try not to suggest role. That's rarely if ever the right way to go. Using the element itself is the solution 99.999999% of the time and messing with roles can introduce problems as I'm sure you know

1
Anosha Ahmedβ€’ 9,300

@anoshaahmed

Posted

@grace-snow Oh, I actually didn't know it could introduce problems. I was suggesting that so they could easily add it, without having to make changes to their html AND to their css.

Thank u for letting me know! I will keep that in mind from now on.

0
TMJβ€’ 120

@TMJSMC53

Posted

@anoshaahmed Thank you! πŸ™‚

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord