Design comparison
Solution retrospective
Hey community members 👋, I hope you all are doing well now & then. I've completed this challenge with the additional feature i.e
- Shake input elements if the given inputs are invalid.
Any feedback to improve this is really appreciated. :)
Community feedback
- @yacineKahlerrasPosted about 2 years ago
Hey Roy good job on the challenge, I just have a few suggestions try adding the dollar sign to the result and tip amount and removing the "Can't be zero" error when clicking buttons or inputing values, also when clicking on one of the tip % buttons it shows results but after that I click the others it doesn't work. that's all happy coding !
0@iprinceroyyPosted about 2 years ago@yacineKahlerras it's made for the purpose. If the inputs you entered are 0, it will pop an error msg, and if again you don't write any values & try to go to the next element without filling that element then an error msg will be popped up. Hope you understand the functionality. 🙂
0@yacineKahlerrasPosted about 2 years ago@iprinceroyy yeah i understand that the inputs can't be zero but even after i input a value that is bigger than 0 the app works correctly but the error still shows even though the value is > 0, hope that helps
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord