Design comparison
Solution retrospective
None was that challenging, I had the concept in my head and knew "how" to do it. I searched how to do it properly a few things but nothing too complex.
What specific areas of your project would you like help with?A overall feedback or some tips/tricks to improve the code will always be appreciated, thanks!
Community feedback
- @Mazz100Posted 8 months ago
Well done on completing the challenge. some tips that could be of some help:
- I think you can minimize the errors for this particular challenge since it's just calculating a tip so don't be strict with error messages.
- Only try making condition on calculating results after user selects all the options or at least 2 of them eg. bill and persons. See what fits with you
- I notice that sometime I need to double-click on each discount to apply it so it seems they are not radio inputs which should be the ideal approach for this case.
- One last thing about calculation I see that total/person is not getting calculated correctly, maybe you forgot to link some logic to it ?
Overall your solution looks great but these were some points to consider especially accessible HTML semantic as much as possible. Don't hesitate to ask for help on discord community and get feedback 👍 Best of luck!
Marked as helpful0@CairoGarbPosted 8 months agoThanks for the comments, @Mazz100! Yeah, the last one I forgot to divide the bill value by number of people. My mistake.
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord