Design comparison
Community feedback
- @techantherePosted almost 3 years ago
Hey, great job! solution matches perfectly with the design.
Just a few suggestions; for html, links are not good for this case as they are used for navigation to a different page, while buttons are perfect for use here. For img with empty alt, it will be great to add aria-hidden="true";, so screen readers ignore it. And hey add some color change for an active daily weekly or monthly stats, button to make it standout.
Happy coding :)
Marked as helpful1@SheGeeksPosted almost 3 years ago@techanthere Will try these adjustments including the color change on active buttons. Nice catch on the missing alt for the ellipsis icon and appreciate the suggestion for accessibility! Will have to save that one for future projects.
1@SheGeeksPosted almost 3 years ago@techanthere Just a quick update that I made these changes and, again, really appreciate your suggestions for the buttons.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord