Responsive three column card UI

Community feedback

• 

  Assurance Chioma Ikogwe•410

  @Aik-202Posted about 2 years ago

  Hey Sounak, this is beautiful! Nice one. I have a suggestion though, for the mobile view maybe trying reducing the padding in your main container... Specifically, the left and right padding, there seem to be too much space at the left and right hand sides of the cards.

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Sounak Mukherjee,

  Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  • To tackle the accessibility issues Page should contain <h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1> visually hidden with .sr-only class.You can find here

  • In my opinion, the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images.

  • What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  • There are a lot the arguments against the changing the root font size ,it state that you should never change the root font size because it harms accessibility.

  Hopefully this feedback helps.

  0

  ---

  

  Sounak Mukherjee•560

  @kanuosPosted about 2 years ago

  @PhoenixDev22 I really appreciate your feedback. I've updated my code accordingly. I only changed the root font size as it was mentioned in the style guide to make the base font size of 15px. Could you throw some light on how to do that?

  Again, thanks a lot for your input!

  0