Skip to content
Submitted almost 3 years ago

Responsive testmonials using GRID

Lucas Vieira•140
@JimCarey08
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Testimonials grid section
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

How can i improve the organization on css file?

Community feedback

  • darryncodes•6,390
    @darryncodesPosted almost 3 years ago

    Hi Lucas,

    Nice work with this one, great use of grid to make the design responsive.

    To answer your question you could look into BEM naming convention and SASS looking into the 7-1 folder architecture

    Some minor bits of feedback from me: (Happy coding!)

    • nice work with the descriptive mark up, if you swap <div class="attribution"> with <footer class="attribution"> you'll clear your accessibility report
    • you should only have one <h1> per design, here is some more info
    • you could centre your design responsively in the viewport with the following styles on your <body> and do away with margin: 0 auto; on your <main> tag
       display: flex;
    flex-direction: column;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
    Marked as helpful
    0
    Lucas Vieira•140
    @JimCarey08Posted almost 3 years ago

    @darryncodes thankss , i will do these on my next challenge!! appreciate the feedback!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord