Responsive testimonials-grid-section-main

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @bbill4552, congratulations on your new solution!

  I’ve some suggestions for you:

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/testimonials-grid-section-vanilla-css-focus-effect-custom-design-e5bIzU3vZN

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  bilal Alqtrawi•210

  @Bilal-AlqtrawiPosted about 2 years ago

  @correlucas Thank you for the clarification and I will take into account everything you said and use the best in writing html codes

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The specify the main content of you site and allow screen readers to skip directly to it, you will want to encase your entire component inside a Main Element.

  ARTICLE

  ARTICLE

  • The profile image needs an Alt Tag. It should state the following; “Headshot of -person’s full name-“

  • To enhance the semantics of your component, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  bilal Alqtrawi•210

  @Bilal-AlqtrawiPosted about 2 years ago

  @vcarames Thank you for the clarification.

  0