Design comparison
Solution retrospective
Hey there! Here is a new challenge, I hope you like it. Looking forward to your recommendations. Thanks!
Community feedback
- @correlucasPosted about 2 years ago
๐พHello again Alba =) , Congratulations on completing this challenge!
I liked a lots the customization you've done here with the card gradients. Amazing.
Youโre in the right track I can see that youโve used the majority semantic tags possible for this challenge, the only block youโve missed is the paragraph containing the
quote text
you can improve the accessibility there using<blockquote>
to indicate to screen readers that the content inside that paragraph is a quote.โ๏ธ I hope this helps you and happy coding!
0 - @mattari97Posted about 2 years ago
Hi Alba. Great job completing this challenge ๐๐๐.
It look really great and minus some small accessibility issues stated in your report that you can easily fix; I have only two small advices to give you.
I would increase the font-size of the
.text
paragraphs in your cards and increase the opacity a bit because it it really small right now which makes it hard to read. I am not that old ๐ and even I have some difficulties reading them.I would also make sure that the
card-image
content always stay vertically centered by adding the propertyalign-items: center
on the container.That's all! Again great job and happy coding ๐ Peace.
0 - @AdrianoEscarabotePosted about 2 years ago
Hi Alba, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Page should contain a level-one heading click here
2- All page content should be contained by landmarks, you can understand better by clicking here: click here
I noticed that the content is stretching a lot in higher resolutions, to fix this we can do the following:
I added:
.container { max-width: 1110px; }
The rest is great!!
Hope it helps...๐
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord