Design comparison
Community feedback
- @tobezhanabiPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you. HTML 🏷️:
This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage So fix it by replacing the element <div class="container"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.
What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span> They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page Another issue with your code your lack of alt attributes in your <img> tags leaves room for poor SEO and recommendation. Fix it by put the alt attributes I hope you find it helpful ! 😄 Above all, the solution you submitted is great
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord