Design comparison
Solution retrospective
I'm proud of the ways I used grids. I tried to make it clean and adaptable to tablets. I'm proud of how I anticipated the time it would take to do it.
I would maybe try to focus more on mobile first but still anticipating more desktop and tablet behaviours.
What challenges did you encounter, and how did you overcome them?I encountered a challenge on how to organize classes and file tree using BEM technology.
What specific areas of your project would you like help with?I'd like help to understand if I understood well BEM technology. Hwat could I have done differently in order to make it more reusable? Thanks :).
Community feedback
- @vgt3j4d4Posted 2 months ago
-
Does the solution include semantic HTML? Yes, definitely!
-
Is it accessible, and what improvements could be made? I believe it is ok.
-
Does the layout look good on a range of screen sizes? Yes, I see it look good not only in mobile and desktop but the grid accomodates itself depending on the dimensions of the viewport. Well done! (I have to admit I only thought on Desktop and Mobile)
-
Is the code well-structured, readable, and reusable? Yes, specially using separately .scss files (partials)
-
Does the solution differ considerably from the design? Nope
- What specific areas of your project would you like help with? I'd like help to understand if I understood well BEM technology. Hwat could I have done differently in order to make it more reusable? Thanks :). I believe it is pretty reusable, not only using scss but the way things were organized. Also, the naming of the css classes, mixins, etc :)
Marked as helpful0@JamesLavironPosted 2 months ago@vgt3j4d4 Thank you for your feedback, it's much appreciated.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord