Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive testimonials section using CSS Grid

Marcos 95

@marcosfsousa

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


No solution is perfect as I'm sure mine isn't. If you see anything that can be improved be sure to let me know. This project was mostly to shake the cobwebs between learning periods.

Thank you for your time.

Community feedback

darryncodes 6,430

@darryncodes

Posted

Hi Marcos,

I know how you feel about shaking off the cobwebs - really solid responsive design here, nice one.

Between 765px - 465px the design is no longer centred. Try margin: 0 auto; on your .wrapper or remove the max-width. Sorry if i'm teaching you to suck eggs.

You could include a <h1> with a screen reader only class to hide it from view to help with the accessibility/html report:

.sr-only {
    position: absolute;
    width: 1px;
    height: 1px;
    padding: 0;
    margin: -1px;
    overflow: hidden;
    clip: rect(0, 0, 0, 0);
    white-space: nowrap; /* added line */
    border: 0;
}

Marked as helpful

1

Marcos 95

@marcosfsousa

Posted

@darryncodes

Hi Darryn !

Thank your for taking the time to review my code. I've added some of your suggestions and it does look better between those specific breakpoints.

I did add an <h1> with an display:none; at the top of the HTML but it didn't do much for those accessibility issues. I've added most of your suggestion to the class now.

0
darryncodes 6,430

@darryncodes

Posted

You're welcome!

Ah yes, although the element will be in the DOM it'll be completely hidden from the display. Add the above code in to your style sheet and try the class <h1 class=".sr-only"></h1>.

All the best!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord