Responsive testimonials section using CSS Grid

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  Hi Marcos,

  I know how you feel about shaking off the cobwebs - really solid responsive design here, nice one.

  Between 765px - 465px the design is no longer centred. Try margin: 0 auto; on your .wrapper or remove the max-width. Sorry if i'm teaching you to suck eggs.

  You could include a <h1> with a screen reader only class to hide it from view to help with the accessibility/html report:

  .sr-only {
      position: absolute;
      width: 1px;
      height: 1px;
      padding: 0;
      margin: -1px;
      overflow: hidden;
      clip: rect(0, 0, 0, 0);
      white-space: nowrap; /* added line */
      border: 0;
  }
  

  Marked as helpful

  1

  ---

  

  Marcos•95

  @marcosfsousaPosted almost 3 years ago

  @darryncodes

  Hi Darryn !

  Thank your for taking the time to review my code. I've added some of your suggestions and it does look better between those specific breakpoints.

  I did add an <h1> with an display:none; at the top of the HTML but it didn't do much for those accessibility issues. I've added most of your suggestion to the class now.

  0
• 

  darryncodes•6,370

  @darryncodesPosted almost 3 years ago

  You're welcome!

  Ah yes, although the element will be in the DOM it'll be completely hidden from the display. Add the above code in to your style sheet and try the class <h1 class=".sr-only"></h1>.

  All the best!

  Marked as helpful

  0