@antoniomontoia
Posted
Semantic HTML
The solution effectively uses semantic HTML elements such as <article>, <blockquote>, and <h1>, which enhance the document's structure and improve SEO. The use of <main> and <footer> also contributes to a clear layout.
Consider using <h2> or <h3> for user names instead of <h1>, as there are multiple testimonials on the page. This adjustment would maintain a proper heading hierarchy.
Design Consistency
The overall design aligns well with typical testimonial layouts, but the design is just a bit off; consider reviewing line-height and font-size to ensure they match the intended design. Limiting the overall width for the cards could enhance the visual appeal and readability. Ensure that the design matches any provided mockups or specifications from the challenge. Pay attention to spacing, font sizes, and color usage to ensure consistency.
Additional Note on BEM Methodology
I'm also struggling with the BEM methodology, so I cannot help you in that regard. However, I recommend reviewing the naming conventions to ensure they follow the BEM principles, which can improve the maintainability and clarity of your CSS.
--
Overall, this solution demonstrates a solid understanding of CSS Grid principles. The use of semantic elements, responsive design, and a clear structure are commendable. Keep up the great work!
Marked as helpful
