Responsive testimonials grid section using CSS Grid

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Marius,

  Congratulations 🎉 for completing this challenge, the testimonials look great and is responsive. There are some issues and suggestions I would like to address:

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. I noticed that you used the desktop-first approach however I would strongly suggest you use the mobile-first approach for future projects as it will be easier for responsiveness and rearranging/changing any element/s within your body. Also, it is best practice to follow this approach.
  3. Instead of using the padding and margin property to center the cards in desktop, you can use the flex property on the cards in desktop mode. Also, if you use this approach I would suggest removing the line-height and reducing the padding of the .card to 30px as this will reduce the size and width of the card to prevent the cards being too big e.g.

  @media only screen and (min-width:1200px) {
  body {
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
    flex-direction: column;
  }
  

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  Marked as helpful

  1
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Marius, congrats for your new solution!

  I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:

  Improve your html markup using meaningful tags and replace the important blocks of content with better tags, for example the main div that takes all the content can be wrapped with <main> or section, the cards you can be replaced the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Don’t use div for the important blocks, ever prefer some tag that shows what its containing the block.

  Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0