
Design comparison
Community feedback
- P@jayco01Posted 20 days ago
Hey! Great job on completing the challenge! Here are a couple of suggestions:
-
Clearer Class Names: Some class names, like .white1 and .white2, don’t really describe what they do. Instead, using names like .testimonial--light or .testimonial--secondary would make it clearer at a glance. This small change can help make your CSS easier to understand and maintain in the future.
-
Simplify the Grid Layout: Right now, you’re setting grid-column-start, grid-row-start, and other grid properties as CSS variables, which is a cool idea, but it might be making things more complicated than necessary. Instead, it would be easier to just define these directly in the .card classes inside the media query. That way, your layout is easier to read and tweak without having to dig through multiple layers of variables.
Hope this helps!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord