Responsive testimonial using CSS Grid

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  Hello Hale, congratulations for this beautiful solution.

  I just saw your live site and the Git repository and your solution is great, the grid is just perfect mobile and desktop.

  I've three tips for semantic and one for the design:

  1.The line-height for the card main heading seems a too much, I think the gap between the lines is around 1.2.

  2.Try to avoid using div for the main blocks, in this case is better wrap these groups elements with a semantically tag. For example, all the elements inside the <main> and <section> for each card and <blockquote> for with paragraph with the text clothe inside. This way you communicate better what is inside each element, div is only a block element without meaning.

  3.If you want to take this challenge to another level you can create a media query for tablet with a different grid layout.

  Your challenge is already good, these tips are only details.

  Hope it helps and happy coding.

  Marked as helpful

  0